Skip to content
This repository has been archived by the owner on Jan 7, 2023. It is now read-only.

[mesa 19.1.6]dEQP-VK.api.external.memory.android_hardware_buffer.* failed due to crash #133

Open
renchenglei opened this issue Sep 29, 2019 · 11 comments

Comments

@renchenglei
Copy link
Contributor

One vulkan external memory case failed on x86 platform due to "crash" on Android 10 with mesa 19.1.6.

dEQP-VK.api.external.memory.android_hardware_buffer.image_formats#r16g16b16a16_sfloat

This issue is also reproduced with mesa 19.0.6. Android framework failed to alloc multi buffers. Then it will report errors. On x86 platform, it seems that the crash is caused by out of heap.
issue is also reproduced with upstream master branch(e4a52bd).
Steps to reproduce this issue(run with cts packages):

run cts -m CtsDeqpTestCases -t dEQP-VK.api.external.memory.android_hardware_buffer.image_formats#r16g16b16a16_sfloat --abi x86
@tpalli
Copy link
Contributor

tpalli commented Oct 3, 2019

This passes for me with Mesa master on KBL NUC, maybe APL specific issue?

@renchenglei
Copy link
Contributor Author

@tpalli, yes, this is APL specific issue. It may be caused by performance issue.

@renchenglei
Copy link
Contributor Author

@tpalli, sorry, maybe I am wrong. This is similar to #134, please upgrade minigbm, and have a double try. :)

@tpalli
Copy link
Contributor

tpalli commented Oct 11, 2019

OK yes, I've reproduced this now on KBL. This seems to trigger 'ubsan: add-overflow', backtrace does not have mesa libraries in it though, this could be an issue within dEQP.

@tpalli
Copy link
Contributor

tpalli commented Oct 11, 2019

This looks like Android framework issue. For me this test passes if I comment out dumpToSystemLog() call from here:

https://android.googlesource.com/platform/frameworks/native/+/jb-mr0-release/libs/ui/GraphicBuffer.cpp#117

@tpalli
Copy link
Contributor

tpalli commented Oct 11, 2019

I think I have a fix for this one now :)

@renchenglei
Copy link
Contributor Author

@tpalli, great! Wait for the fix!

@tpalli
Copy link
Contributor

tpalli commented Oct 11, 2019

Here's a hopeful fix, if it works out well I will upstream this for Android.

0001-libui-use-uint64_t-to-avoid-overflow-issues-with-big.log

I've tested this only on KBL but there it makes the test pass.

@renchenglei
Copy link
Contributor Author

Thanks, I will have a test on APL(NUC or GP). Will be back asap. :)

@renchenglei
Copy link
Contributor Author

@tpalli, tried with your above changes, and case also could pass on APL NUC. :)

@tpalli
Copy link
Contributor

tpalli commented Oct 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants