Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Disable] Colors Out of Combat not working #45

Open
pupsader1 opened this issue Jun 20, 2024 · 5 comments
Open

[Disable] Colors Out of Combat not working #45

pupsader1 opened this issue Jun 20, 2024 · 5 comments
Assignees
Labels

Comments

@pupsader1
Copy link

Hey there, your addon is an essential part of my kit, thanks for making it.

I like to turn off the Colors Out of Combat, because I play hardcore and I'm trained that RED is BAD. So I turn this off, however it is amusingly giving it 3 different colors for the same mob

Screenshot 2024-06-20 182518

Would love to see a fix for this.

Thanks!!

@mikfhan
Copy link
Collaborator

mikfhan commented Jun 22, 2024

I don't want to be the cause of a character wipe! xD I've had some trouble with nameplates not detecting all update events sometimes, can you provoke a color update when you move far enough away so the plate disappears, then move closer again?

It's a pretty resilient bug, something about the end of combat event not triggering always, but gradient updates would suggest otherwise since they run x times every second anyway. More likely the internal tracking of nameplates to mobs somewhere loses a nameplate, or the reset nameplate does not work always, especially if I enable/disable color out of combat then plates dont even change immediately, often I must /reload to force it. Probably a combination of two bugs really.

@pupsader1
Copy link
Author

Thanks for the reply. I am training myself to use the new colors now XD

Here's a couple of clips that can show it better than I can explain, lol.
Interesting is that another player can cause the colors to change. The colors are properly set again after a reload, until someone enters combat.

Recording.2024-06-22.165847.mp4
Recording.2024-06-22.170151.mp4

@mikfhan
Copy link
Collaborator

mikfhan commented Jul 15, 2024

Hmm, yeah I remember at one point I had to expand how I detect combat a bit, something about being the healer in a party and others going into melee but I hadn't myself joined combat yet - maybe that logic somehow also runs for friendly players NOT actually in the group xD will have to look into that soon just been some busy weeks this summer sadly, thanks for the clips!

@mikfhan mikfhan self-assigned this Jul 27, 2024
@mikfhan mikfhan added the bug label Jul 27, 2024
@mikfhan
Copy link
Collaborator

mikfhan commented Jul 27, 2024

I tried to force the red/yellow color reset a bit harder now in 4.3-release :) do reply back if it's still broken.

@mikfhan
Copy link
Collaborator

mikfhan commented Sep 1, 2024

Is this issue still happening in 4.4-release and later? Please reply below or I am tempted to close this old one by 2025 new year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants