Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add state management, routing #201

Merged
merged 14 commits into from
Jan 8, 2024

Conversation

minikin
Copy link
Collaborator

@minikin minikin commented Jan 1, 2024

Description

Add foundational implementation of state management and routes.

🚨🚨🚨 Note for the reviewer:
These are the fundamental implementations of state management, repositories, services, and other classes.
You can think about it as guidance for Catalyst Voices Frontend App Architecture. As soon as the data and user flows are defined, the recent implementation will be replaced with concrete implementations.

Related Issue(s)

Closes #76, #77

Description of Changes

Add foundational implementation of state management and routes.

Breaking Changes

None

Screenshots

Not applicable

Related Pull Requests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@minikin minikin self-assigned this Jan 1, 2024
@minikin minikin added do not review yet Do not review yet draft Draft labels Jan 1, 2024
@minikin minikin removed do not review yet Do not review yet draft Draft labels Jan 5, 2024
@minikin minikin marked this pull request as ready for review January 5, 2024 13:44
@minikin minikin added the review me PR is ready for review label Jan 5, 2024
@minikin minikin requested a review from stevenj January 5, 2024 13:44
@minikin minikin enabled auto-merge (squash) January 5, 2024 13:45
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit 088ebcc into main Jan 8, 2024
20 checks passed
@minikin minikin deleted the feature/frontend-navigation-state-managment branch January 8, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add state management
2 participants