feat(service): schema mismatch disables service #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saibatizoku
changed the title
saibatizoku
requested review from
stevenj,
Mr-Leshiy,
FelipeRosa,
cong-or and
minikin
as code owners
…hods Adds `State::event_db()` which returns an optional handle to the DB connection pool Adds `State::schema_version_check()` which retuns the result of the schema version check query Adds `State::is_schema_version_status(svs)` which compares the inner value with the argument Adds `State::set_schema_version_status(svs)` which sets the inner value with the argument
Add middleware type to check the State's schema version status variable, if a mismatch is detected, a `503 Service unavailable` response is returned.
saibatizoku
force-pushed
the
feature/schema-mismatch-disables-service
branch
from
7793da5 to
65180ff
Compare
Mr-Leshiy
reviewed
Jan 3, 2024
catalyst-gateway/bin/src/service/utilities/middleware/schema_validation.rs
Outdated
Show resolved
Hide resolved
catalyst-gateway/bin/src/service/utilities/middleware/schema_validation.rs
Show resolved
Hide resolved
saibatizoku
force-pushed
the
feature/schema-mismatch-disables-service
branch
from
9adf677 to
d195378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds feature to the
poemweb service which disables it from serving HTTP requests if a DB schema version mismatch has been detected.Related Issue(s)
Closes #47
Description of Changes
poemmiddlewareSchemaVersionValidationto disable the service from responding to requests if a schema version mismatch has been detected.crate::state::Statesuch that inner variables can only be accessed using methods.State::event_db()which returns an optional handle to the DB connection pool.State::schema_version_check()which retuns the result of the schema version check query.State::is_schema_version_status(svs)which compares the inner value with the argument, returnsbool.State::set_schema_version_status(svs)which sets the inner value with the argument.Related Pull Requests
#197
Please confirm the following checks