Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ndarray Keyword Argument #356

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Remove ndarray Keyword Argument #356

merged 6 commits into from
Jul 29, 2024

Conversation

pulsipher
Copy link
Collaborator

This PR removes ndarray as a keyword argument and essentially makes ndarray = true the default behavior. Users that still prefer to get a vector output can simply use vec to vectorize.

This PR simplifies the way TranscriptionOpt reports back mappings, improves printing for transcribed variables, and enhances the robustness/efficiency of making n-dimensional arrays for transcribed mappings.

@pulsipher pulsipher added breaking This will introduce breaking changes to the API simplification Simplify the underlying complexity transformations Something to do with model transformations labels Jul 29, 2024
@pulsipher pulsipher added this to the v0.6 milestone Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (0157256) to head (f9b4600).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
- Coverage   99.77%   99.77%   -0.01%     
==========================================
  Files          35       35              
  Lines        6758     6722      -36     
==========================================
- Hits         6743     6707      -36     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pulsipher pulsipher merged commit 3a85a93 into master Jul 29, 2024
10 checks passed
@pulsipher pulsipher deleted the remove_ndarray branch July 29, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This will introduce breaking changes to the API simplification Simplify the underlying complexity transformations Something to do with model transformations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant