Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixin Conflict Crash with Galosphere installed with latest 1.20.1 update #8

Open
Liamgrayskull opened this issue Jun 1, 2024 · 6 comments

Comments

@Liamgrayskull
Copy link

Sinytra/Connector#1121 (comment)

https://gist.github.com/Liamgrayskull/c154b9308cbd7733128b916c8c943040

@Lyof429
Copy link
Collaborator

Lyof429 commented Jun 1, 2024

I can't really do anything, unless mixins can be made not to load of a specific mod is loaded .-.
We both redirect the same method for the same purpose, yeeting one of them would just break a functionality

@Liamgrayskull
Copy link
Author

O p e alright, well this helps in knowing where to resolve it! I'm sure I can figure some sort of compatibility out for my specific instance, I'm not sure how you'd prevent a mixin from loading when another mod is loaded, I've seen in done in logging but this is a relatively niche issue through connector anyways. Do you know if forge is following the 1.20.1 port or is fabric only supported atm?

@Lyof429
Copy link
Collaborator

Lyof429 commented Jun 2, 2024

Would be great if you found a way yeah, let me know if you do ^^'
If you somehow find a way to cancel your mixin, I can implement it on my side too so your stuff doesn't stop working, considering it's not something that needs galosphere to be loaded - NBT tags are in base mc
There might be a forge port coming but I don't know when
So for now, consider only fabric is supported ig

@Lyof429
Copy link
Collaborator

Lyof429 commented Jun 2, 2024

I'm back after doing some research
https://github.com/Bawnorton/MixinSquared/wiki/Mixin-Canceller
This api apparently lets one cancel mixins at runtime - which means either

  • you could cancel your mixin on load if you detect Sortilege to be present, and I'd reimplement it on my side
  • I could cancel yours whatever happens and reimplement it anyway on my end

Let me know which solution you prefer. Anyway I need to implement your tag based keeping system, but one of us has to use the API and handle the mixing cancellation

@Liamgrayskull
Copy link
Author

Liamgrayskull commented Jun 3, 2024

I'm back after doing some research https://github.com/Bawnorton/MixinSquared/wiki/Mixin-Canceller This api apparently lets one cancel mixins at runtime - which means either

  • you could cancel your mixin on load if you detect Sortilege to be present, and I'd reimplement it on my side
  • I could cancel yours whatever happens and reimplement it anyway on my end

Let me know which solution you prefer. Anyway I need to implement your tag based keeping system, but one of us has to use the API and handle the mixing cancellation

I might've miscommunicated the fact that I'm devving the mod, I'm not- I just stumbled upon the error while pack developing, but I'd be happy to forward the issue if need be! This issue tracker is more active so I opted to report it here initially- I appreciate the research greatly- anything I can help with in implementation, let me know.

@Lyof429
Copy link
Collaborator

Lyof429 commented Jun 3, 2024

Oh okay, I thought you were the dev x)
Yeah would be great if you could forward that to them 👍
Thanks for your quality dedication even if you're not in charge though, it's great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants