[1.19.2] Persistently save XP saves for entities #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonathing
commented
Dec 14, 2024
There was a problem hiding this comment.
The way I wrote the capability for this PR is entirely in my style. I don't exactly know how you would write them since this mod doesn't have any in the first place. It probably isn't a big deal since it doesn't seem like you currently have plans to port the Forge version to 1.20.1, but I wanted to let you know regardless.
Comment on lines
+70
to
+72
| public static void setSavedXp(LivingEntity entity, int xp, boolean onlyIfZero) { | ||
| EntityXpStorage.ifPresent(entity, storage -> storage.setXp(xp, onlyIfZero)); | ||
| } |
There was a problem hiding this comment.
There were a couple of spots in ModEvents where you used XPHelper.XP_STATS.putIfAbsent(), which wouldn't have replaced the original value if there was one already there. I don't know if this is a bug on your part, but just in case, this parameter onlyIfZero mimics the putIfAbsent behavior of the old code.
Jonathing
force-pushed
the
feat/jonathing/1.19.2/persistent-xp-saves
branch
from
d703dda to
6114923
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a forge capability to replace
XPHelper.XP_SAVES. This allows for XP stats saved by Sortilege to also be saved to disk, eliminating the root cause of various XP loss issues.Additionally,
.gitignoreand.gitattributesfiles were added to streamline the process of comitting files to the repository. Also, a small closure was added to the buildscript to assist with IntelliJ IDEA refusing to download linked source and javadoc files.