Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped working at GitLab #79

Open
IzzySoft opened this issue Dec 18, 2021 · 10 comments
Open

Stopped working at GitLab #79

IzzySoft opened this issue Dec 18, 2021 · 10 comments
Labels
bug Something isn't working

Comments

@IzzySoft
Copy link

Describe the bug
On GitLab, the addon stays entirely dormant, claiming it has no internet access ("You have to be connected to the Internet"). On Github it claims the same, but at least the functionality is still there (the browser pane is available) – same on Gitea instances.

To Reproduce
Steps to reproduce the behavior:

  • install the addon
  • visit GitLab, Github, Codeberg…

Expected behavior
No such message, but the usual selection list being shown when tapping the icon from the toolbar – and the browser pane being available at GitLab as well.

Screenshots
image

Context (please complete the following information):

  • Platform(GitHub, GitLab, Gitee, Gitea): all, with GitLab being most affected
  • Browser and Version: Waterfox Classic, Waterfox G3 (both in their latest version)
  • GitMaster Version: 1.17.0, but it started out-of-the-blue with 1.16.1

Additional context
The issue started out-of-the-blue with the addon working fine yesterday (still being on 1.16.1). An update to 1.17.0 didn't solve it. I suspect the URL you use to check internet activity might have been caught by some blacklist – but that would not explain why it partly works on Github and Gitea (with the pane working fine) but stopped entirely for GitLab. As I don't know how you check, I cannot verify.

@IzzySoft IzzySoft added the bug Something isn't working label Dec 18, 2021
@IzzySoft
Copy link
Author

IzzySoft commented Feb 5, 2022

Am I the only one with this issue (which still persists with 1.17.1), or can someone confirm?

@jedchang
Copy link

jedchang commented Feb 7, 2022

the same situation

@ineo6
Copy link
Owner

ineo6 commented Feb 9, 2022

Work fine for me(classic).

The message you see belongs to GitHub Notification feature, so you can check 'Preferences' page.

@IzzySoft
Copy link
Author

IzzySoft commented Feb 9, 2022

Work fine for me(classic).

For GitLab? Fails for me with Classic and G3 (no sidebar). All others (Gitea, Github) work fine. And if that message just concerns Github notifications, I can simply ignore it, thanks 😉

@guoxianru
Copy link

guoxianru commented Feb 10, 2022

the same situation Google Chrome 98.0.4758.82

@ineo6
Copy link
Owner

ineo6 commented Feb 10, 2022

Attention!

When you visit gitlab.com by Classic version(G3 maybe also), there is an error:"ReferenceError: customElements is not defined".

image

I think the reason is Classic or G3 too old, try latest version G4.

@IzzySoft
Copy link
Author

As it worked before, it's either a change at GitLab breaking compatibility (wouldn't be the first) or in the addon. I guess it's the former, as it happened out of the blue and not "right after an update". And no, changing the browser is not an option. I don't have time to configure another browser all few weeks just because some devs (here: at GitLab) think they need to implement some crazy stuff just because they can – as said, this is not the first time (and wouldn't be the first time they had to revert things as they broke compatibility).

Besides: Console output here (in G3) ends one line earlier, with the apis.google.com line.

@IzzySoft
Copy link
Author

Currently it's working fine. Just with Waterfox G4 it always forgets the Github API token (keeps it fine in classic). Any idea what that could be?

@IzzySoft
Copy link
Author

Updated to G5. Access token still forgotten regularly. Wish I knew where to check or how to fix that. Oh, maybe it's related to this one 😱 I've disabled the LocalStorage part of it and will see if that helps.

@IzzySoft
Copy link
Author

The access token being forgotten was indeed the linked reason (and long solved for me). But GitLab again stopped working for me; latest Waterfox G6 here meanwhile. Still hoping you will pick up development again one day, @ineo6 – and hopefully find out what is behind this. Looking forward to an update. Unfortunately I'm not familiar with TS and addon development or I had checked myself. None of the forks has something either…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants