Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notary poll interval #74

Open
hneiva opened this issue Apr 20, 2023 · 1 comment
Open

Notary poll interval #74

hneiva opened this issue Apr 20, 2023 · 1 comment
Labels
apple-codesign apple-codesign crate and rcodesign CLI tool enhancement New feature or request good first issue Good for newcomers

Comments

@hneiva
Copy link

hneiva commented Apr 20, 2023

wait_poll_interval: Duration::from_secs(3),

I'm seeing a lot of "Connection reset by peer" errors, and wanted to extend the poll interval, but it looks like it's hard coded.

Some options here are:

  1. Ability to pass it in from cli
  2. Env variable (although I don't think rcodesign uses any env variables for config)
  3. Dynamic regulate timeout (increase every call by X seconds, up to ~30 seconds per call)
@indygreg indygreg added apple-codesign apple-codesign crate and rcodesign CLI tool enhancement New feature or request good first issue Good for newcomers labels Nov 4, 2023
@indygreg
Copy link
Owner

indygreg commented Nov 4, 2023

We should automatically retry for TCP level errors.

In addition, I support making the polling interval configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple-codesign apple-codesign crate and rcodesign CLI tool enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants