-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproduce graphs from original data #8
Comments
I don't have that CSV any more, sorry. |
Thanks. We could create that CSV from the graph, I suppose. I'm thrilled that the other graphs seem to be recreatable without problems. We'll need to compare the results, though. |
Just to understand, is it necessary to recreate the networks from the original source or are you just testing the scripts that do so? |
No, it's not necessary, just good practice. |
Do you mean the package should contain a copy of the datasets? Or we store them somewhere else? |
I don't mind a copy of the raw data on GitHub. |
so the task is to try and locate the yeast and airport data? how do we compare the obtained graphs? |
reg the yeast data, it probably is in https://www.nature.com/articles/nature750 but I don't have access (and even if we get access I suppose the data isn't really free to share 😅 ) |
Yes, yeast seems solved. The only tricky challenge is to reverse-engineer the CSV file, but I'm not sure it's worth it. |
so what are the TODOs? |
|
Wait so we need 3 new issues, this issue is not really closed then? |
One issue is fine. |
Done by
inst/getdata.R
, I have trouble recreatingyeast
andUSairports
.yeast
are not found,cannot open URL 'https://www.nature.com/nature/journal/v417/n6887/extref/nature750-s1.doc': HTTP status was '404 Not Found'
, new location linked at https://www.nature.com/articles/nature750#Sec8USairports
relies on~/Downloads/1067890998_T_T100D_SEGMENT_ALL_CARRIER.csv
@gaborcsardi: Can you help with the
.csv
file?Moving forward, I propose to separate the downloads from the creation of the graphs so that we're less reliant on external data storage here.
The text was updated successfully, but these errors were encountered: