Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc for API persistents and events #49

Open
ickerio opened this issue Jun 5, 2022 · 3 comments
Open

Javadoc for API persistents and events #49

ickerio opened this issue Jun 5, 2022 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation low priority Non urgent

Comments

@ickerio
Copy link
Owner

ickerio commented Jun 5, 2022

Is your feature request related to a problem?

Would be good to generate a javadoc of our API so that other mods can hook in

Describe the solution you'd like.

A javadoc would be ideal or just a wiki page outlining the events and persistent objects

Describe alternatives you've considered.

Having no docs but means its hard to extend this mod

Other

No response

@ickerio ickerio added documentation Improvements or additions to documentation low priority Non urgent labels Jun 5, 2022
@ickerio ickerio changed the title Javadoc for API persistants and events Javadoc for API persistents and events Jun 5, 2022
@PyPylia PyPylia self-assigned this Jun 6, 2022
@ickerio
Copy link
Owner Author

ickerio commented Jul 10, 2022

@BlueZeeKing has set this up (https://ickerio.github.io/factions/index.html) I reckon the Github Action javadoc could be merged into and ran on the publish action, though not a massive priority. Just need to write comments now

@BlueZeeKing
Copy link
Collaborator

I reckon the Github Action javadoc could be merged into and ran on the publish action

I just updated the publish workflow to include the Javadoc (4c6e254). I kept the old workflow just in case, though.

@PyPylia
Copy link
Collaborator

PyPylia commented Jul 10, 2022

I can definitely work on documenting everything with Javadocs. Once the Javadoc comments are finished I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation low priority Non urgent
Projects
None yet
Development

No branches or pull requests

3 participants