You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have noticed that for the weights in the analysis their computation and access is done through the SrcDetSigYieldWeightsService object.
This object has 2 different methods form computing the weights (.calculate() ) and for retrieving the values ( .get_weights() ).
When working with multiple processors, the same SrcDetSigYieldWeightsService is called by all processors, so it might happen that the values from .get_weights() might be not the correct ones if another processor made a .calculate() before.
These would potentially give wrong results for analysis using more than one processor.
A potential fix would be to generate a copy of SrcDetSigYieldWeightsService for each processor used, similar to what is done with other objects such as FluxModels and ParamGridSet.
The text was updated successfully, but these errors were encountered:
Because Python cannot really run things in parallel while using the same data, a copy will be made automatically when data is changed. So I'm quite certain that there is no bug. But feel free to prove me wrong ;)
I have noticed that for the weights in the analysis their computation and access is done through the SrcDetSigYieldWeightsService object.
This object has 2 different methods form computing the weights (.calculate() ) and for retrieving the values ( .get_weights() ).
When working with multiple processors, the same SrcDetSigYieldWeightsService is called by all processors, so it might happen that the values from .get_weights() might be not the correct ones if another processor made a .calculate() before.
These would potentially give wrong results for analysis using more than one processor.
A potential fix would be to generate a copy of SrcDetSigYieldWeightsService for each processor used, similar to what is done with other objects such as FluxModels and ParamGridSet.
The text was updated successfully, but these errors were encountered: