-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion to remove standard_llh #374
Comments
Thanks, yes, I think we should make |
The same behaviour is observed when I use |
Does |
Do you mean performance in terms of runtime? I have never tested it, so I don't have numbers, but I feel that it will not make a big difference. |
In principle the |
I have been using Jannis Flaires catalogue to calculate its sensitivity:
The two likelihoods tested are:
standard_llh
standard_matrix
The n_s bias plots look like:
standard_llh
bias_n_s-25.pdf
standard_matrix
bias_n_s-26.pdf
Similar behaviour appears in the gamma bias plots. I also tested sub catalogues of Flaires with 100, 200, 300 and 400 sources and the behaviour it's the same: a huge deviation is observed when using the
standard_llh
(even with fewer sources), which it seems to disappear when usingstandard_matrix
. Do we know why? Should we perhaps reconsider usingstandard_llh
at all?The text was updated successfully, but these errors were encountered: