Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship name does not always update in Ship panel when changing ships #24

Open
iaincollins opened this issue Sep 19, 2022 · 2 comments
Open
Labels
Bug Something isn't working as intended Data Issue Relating to incorrect or missing data Ship Panel Unconfirmed Behavior not yet replicated

Comments

@iaincollins
Copy link
Owner

iaincollins commented Sep 19, 2022

It's probably missing a check when some events relevant to changing ship occur. I've observed this on a Fleet Carrier so it might be that it's related to changing ships and/or jumping in a carrier and/or using Apex. It is hard to replicate so it's at least a bit of an edge case.

I think it's also missing ship renaming events, so should look at that too.

Specifically - in addition to whatever events are need to track changing ship - it should also listen for Set User Ship Name event and update name/ident in Ship model when it changes.

@iaincollins iaincollins added Bug Something isn't working as intended Ship Panel Data Issue Relating to incorrect or missing data labels Sep 19, 2022
@iaincollins iaincollins added this to the v0.17.0 milestone Sep 19, 2022
@iaincollins
Copy link
Owner Author

So far I have not been able to replicate this just by changing ships in the usual way (i.e. via shipyard).

@iaincollins iaincollins removed this from the v0.17.0 milestone Sep 21, 2022
@iaincollins iaincollins added the Unconfirmed Behavior not yet replicated label Sep 21, 2022
@iaincollins
Copy link
Owner Author

iaincollins commented Sep 21, 2022

Moved to the backlog until can identify a scenario which can be used to replicate this bug - other than the specific case of renaming, which should also be in scope I guess but is not specifically the bug I've seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as intended Data Issue Relating to incorrect or missing data Ship Panel Unconfirmed Behavior not yet replicated
Projects
None yet
Development

No branches or pull requests

1 participant