You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
Now we have quite flat validation algorithm for persistent modifiers - it does many checks in one step, this leads to impossiblity of handling all validation-failure cases properly. For example, if we're trying to validate block section (S) for some header (H) and validation fails at the first step then there are few cases which further application handling depends on:
S does not really relates to H - so we should just invalidate S
Now we have quite flat validation algorithm for persistent modifiers - it does many checks in one step, this leads to impossiblity of handling all validation-failure cases properly. For example, if we're trying to validate block section (
S
) for some header (H
) and validation fails at the first step then there are few cases which further application handling depends on:S
does not really relates toH
- so we should just invalidateS
S
relates toH
but was malformed - here we should invalidateS
and alsoH
Current validation implementation in Scorex does not allow to distinguish case 1 and 2.
https://github.com/ScorexFoundation/Scorex/blob/8adeddbaba7a49e0614f7df7de31fcaf73a263de/src/main/scala/scorex/core/NodeViewHolder.scala#L268
The text was updated successfully, but these errors were encountered: