You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
Right now the message DataFromPeer is received by two actors: PeerSynchronizer and NodeViewSynchronizer. And it is sent by NetworkController, which has a sophisticated and generic message handling mechanism to decide if it should send a DataFromPeer message to PeerSynchronizer or to NodeViewSynchronizer.
The question is: do we need all this generality? I think it is compromising clarity and making the code that handles these messages in PeerSynchronizer and NodeViewSynchronixer more complex than it needs to be. Maybe there is a simpler to accomplish the same thing, although I don't have a clear idea how at the moment.
Maybe a first step could be to specialize DataFromPeer into more specific message classes, such as ModifiersFromPeer, InvDataFromPeer, SyncInfoFromPeer, PeersFromPeer, and so on...
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now the message
DataFromPeer
is received by two actors:PeerSynchronizer
andNodeViewSynchronizer
. And it is sent byNetworkController
, which has a sophisticated and generic message handling mechanism to decide if it should send aDataFromPeer
message toPeerSynchronizer
or toNodeViewSynchronizer
.The question is: do we need all this generality? I think it is compromising clarity and making the code that handles these messages in
PeerSynchronizer
andNodeViewSynchronixer
more complex than it needs to be. Maybe there is a simpler to accomplish the same thing, although I don't have a clear idea how at the moment.Maybe a first step could be to specialize
DataFromPeer
into more specific message classes, such asModifiersFromPeer
,InvDataFromPeer
,SyncInfoFromPeer
,PeersFromPeer
, and so on...The text was updated successfully, but these errors were encountered: