Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] LOG_LEVEL is for Level, not for advanced log filtering. #5247

Open
0x009922 opened this issue Nov 19, 2024 · 0 comments
Open

[BUG] LOG_LEVEL is for Level, not for advanced log filtering. #5247

0x009922 opened this issue Nov 19, 2024 · 0 comments
Labels
Bug Something isn't working config-changes Changes in configuration and start up of the Iroha

Comments

@0x009922
Copy link
Contributor

Context

#4837 introduced a significant change to the configuration: logger.level parameter is now not just a level, but actually a set of filtering directives. This has a few problems:

  • Using level parameter is inappropriate for this configuration. Level is level, not an advanced filter.
  • Not documented anywhere neither that this change was made nor how to use these filters. I found it by accident (thanks to tests) in JS SDK when expected that { "logger": { "level": "TR" } } payload for POST /configuration will fail.
    • It must be reflected on Torii reference (config reference is still wip)

Additionally, it just feels frustrating that after emphasizing many times in the Config RFC #3795 that configuration must be taken extra care of in terms of documentation, proper design choices, and breaking changes.

Proposal

  • Revert logger.level (LOG_LEVEL) to be strictly log level as before
  • Introduce logger.filter (LOG_FILTER) in addition to it. Document it's usage well
  • They can work both, without conflicts, since they could work on different layers of tracing
@0x009922 0x009922 added Bug Something isn't working config-changes Changes in configuration and start up of the Iroha labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working config-changes Changes in configuration and start up of the Iroha
Projects
None yet
Development

No branches or pull requests

1 participant