Missing HomographyMethodRHO HomographyMethod added #1191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This is my first pull-request here. There is a link to the official OpenCV documentation attached to the
FindHomography
function. It mentions four supported homogpraphy methods, but in gocv only three of them have been implemented. I ran local tests on whether the library can work with the RHO method, and all the tests were successful. In accordance with the documentation, I propose to add the missing method.I also noticed an inconsistency in the names of values and the type (HomographyMethod/HomograpyMethod), but I assume that due to compatibility with previous versions of the library, it will be hard to correct this (marking old values as deprecated and adding new ones without a typo?).
Greetings