Skip to content
This repository has been archived by the owner on May 9, 2022. It is now read-only.

Provide mutable versions of exact_match and longest_match #6

Open
heroin-moose opened this issue Jun 19, 2018 · 6 comments
Open

Provide mutable versions of exact_match and longest_match #6

heroin-moose opened this issue Jun 19, 2018 · 6 comments

Comments

@heroin-moose
Copy link

If a tree node holds some mutable structure (like HashMap) it's desirable to modify it inline without removing, modifying and inserting it back.

@DRiKE
Copy link

DRiKE commented Aug 30, 2018

I needed this as well for longest_match and came up with a very rudimentary version in https://github.com/zesplot/treebitmap/tree/longest_match_mut

It lacks tests and documentation, as I'm not sure whether this (i.e., repeating the immutable version of the function) is the desired way of doing it. @hroi , if you think it is, I can add tests+docs and create a pull request.

@heroin-moose
Copy link
Author

Yeah, I did the same xD
The problem is -- the author seems to be dead. We either need to fork this project or to call a necromancer.

@pusateri
Copy link

Thanks for the mutable version of longest_match_mut(). I needed this too.

@hroi
Copy link
Owner

hroi commented May 22, 2019

My thanks to whoever called the necromancer. I will try to get my shit together and stop neglecting this repo. If someone wants to help maintain it, please let me know!

@hroi hroi closed this as completed in 56c6f47 May 22, 2019
@hroi
Copy link
Owner

hroi commented May 22, 2019

Closed the wrong issue.

@hroi hroi reopened this May 22, 2019
@heroin-moose
Copy link
Author

heroin-moose commented May 25, 2019

Yay, @hroi has been revived ^_^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants