Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option ‘--headful’ doesn’t run GToolkit headfully #654

Open
Rinzwind opened this issue Aug 16, 2024 · 6 comments
Open

Option ‘--headful’ doesn’t run GToolkit headfully #654

Rinzwind opened this issue Aug 16, 2024 · 6 comments
Labels

Comments

@Rinzwind
Copy link
Contributor

When used with ‘GToolkit64-release’ as in the following, the option --headful doesn’t run it headfully:

./bin/smalltalkci --headful --smalltalk GToolkit64-release
@Rinzwind
Copy link
Contributor Author

Also, when opening the ‘GlamorousToolkit’ app (on macOS) in the folder in the ‘_builds’ folder, the image runs without opening a window, which is related to GToolkit issue #3901.

@fniephaus
Copy link
Member

Hi @Rinzwind, thanks for opening the ticket. I guess your last comment implies that this is a GToolkit bug?

@Rinzwind
Copy link
Contributor Author

I suspect the problem in the first comment is due to not passing --interactive to GlamorousToolkit-cli. That causes the problem in the second comment due to the GToolkit issue.

@fniephaus
Copy link
Member

It seems the GToolkit integration does not handle is_headless.
Squeak sets specific VM flags:

smalltalkCI/squeak/run.sh

Lines 295 to 304 in 75da829

if is_travis_build || is_headless; then
case "$(uname -s)" in
"Linux")
vm_flags="-nosound -vm-display-null"
;;
"Darwin"|"CYGWIN_NT-"*|"MINGW64_NT-"*)
vm_flags="-headless"
;;
esac
fi

Pharo picks another launcher: https://github.com/hpi-swa/smalltalkCI/blob/75da829008f23bf1cd5e83b3b7904ffc4ae4ca55/pharo/run.sh#L270C6-L274

Maybe this is something @seandenigris could look into?

@Rinzwind
Copy link
Contributor Author

Regarding the problem related to GToolkit issue #3901: smalltalkCI may need to use ‘GlamorousToolkit-image-without-world.zip’ as suggested in a comment in the issue, at least for the scenario of building an image headlessly on a CI server and then locally running it headfully.

@seandenigris
Copy link
Contributor

seandenigris commented Sep 21, 2024

I’ve compiled all the hints I’ve collected here: feenkcom/gtoolkit#3901 (comment). I think I have a path forward, but I'm waiting on two points of clarification from the Feenk team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants