Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional geometries shouldn't be clipped by project area #2004

Open
manjitapandey opened this issue Dec 19, 2024 · 3 comments
Open

Additional geometries shouldn't be clipped by project area #2004

manjitapandey opened this issue Dec 19, 2024 · 3 comments
Assignees
Labels
backend Related to backend code priority:high Should be addressed as a priority testing:ready Ready for testing

Comments

@manjitapandey
Copy link
Contributor

Requirement from Tokha field mapping exercise.
As they are uploading road network for additional entity, sometimes the road network could get out of exact project area. The current behavior is while viewing the data on odk the features are clipped by project area. Only the features whose centroid lies in project area are shown. This causes major roads to be removed.

Expected Behavior
In such cases the additional entities shouldn't be clipped by project geometry.

@manjitapandey manjitapandey added the priority:high Should be addressed as a priority label Dec 19, 2024
@Sujanadh Sujanadh self-assigned this Dec 20, 2024
@Sujanadh Sujanadh added the backend Related to backend code label Dec 20, 2024
@spwoodcock
Copy link
Member

The clipping should probably be based on the geom type in general.

We can determine the geom type on upload.

If linestrings, do not clip them to AOI

@Sujanadh
Copy link
Collaborator

I think supporting dataset, whether it is polygon or linestring, can still be outside project AOI. I don't think we need to clip additional entities with project AOI at all.

@spwoodcock
Copy link
Member

spwoodcock commented Dec 23, 2024

True! I think I misread the issue. It makes sense to apply to clipping, as the user has to generate the dataset themselves first (and will likely only provide the exact geom they need) 👍

@manjitapandey manjitapandey added the testing:ready Ready for testing label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code priority:high Should be addressed as a priority testing:ready Ready for testing
Projects
None yet
Development

No branches or pull requests

3 participants