Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra project advanced config option for new point collection: point, polygon, polyline #1979

Open
spwoodcock opened this issue Dec 11, 2024 · 2 comments
Labels
backend Related to backend code effort:medium Likely a day or two enhancement New feature or request frontend Related to frontend code priority:low Backlog of tasks that will be addressed in time

Comments

@spwoodcock
Copy link
Member

spwoodcock commented Dec 11, 2024

Is your feature request related to a problem? Please describe.

  • We can currently add a new point in FMTM and have it injected as the new_feature field in the XLSForm.
  • The XLSForm field is currently geopoint.
  • Ideally we can have this configurable, so we inject the field as geotrace (polygon) or geoshape (polygon), and allow the user to draw the relevant geometry in FMTM to inject.

This is a follow up issue from #1915

Describe the solution you'd like

  • Add a config option for this during project creation.
  • Add a db field for projects to capture this, as an enum with three options.
  • Based on the enum value in the project JSON in the frontend, we change the terradraw geom type: point, polyline, polygon.
  • We may need to add buttons for deleting and modifying vertices if drawing more complex polygons.
  • The update_form function in osm-fieldwork should have the option to specify the new geom type, so the XLSForm has the relevant field type.

Additional context

  • This may be dependent on moving the mandatory XLSForm questions sheet out of the XLS file and directly into code (to make things easier).
@spwoodcock spwoodcock added backend Related to backend code effort:medium Likely a day or two enhancement New feature or request frontend Related to frontend code priority:low Backlog of tasks that will be addressed in time labels Dec 11, 2024
@manjitapandey
Copy link
Contributor

We can currently add a new point in FMTM and have it injected as the new_feature field in the XLSForm.

Is this new_feature becomes an entity and can we use it in visualising the bad submissions??

cc: @spwoodcock , @Sujanadh

@spwoodcock
Copy link
Member Author

Yes we can for sure!

Either:

  • Make an API call to get entity ids and statuses. Then fetch the geoms via their entity id.

  • (preferred) insert the new geoms and bad geoms into an FMTM database table. Have the table reactive via electric again. The geometries will be loaded on the map real time as they are mapped or marked bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code effort:medium Likely a day or two enhancement New feature or request frontend Related to frontend code priority:low Backlog of tasks that will be addressed in time
Projects
Development

No branches or pull requests

2 participants