Unexpected 404 Response Despite Correct Terminal Output Logging

[bajrangCoder]

I recently transitioned from expressjs to hono, and I've encountered an issue where the server returns a 404 Not Found response instead of the expected output. Strangely, the terminal logs the correct output. Previously, I encountered an error about content not being finalized. After consulting the documentation, I discovered the use of await next(). However, since implementing this, I've been facing a 404 error. As I'm new to hono, I would appreciate any assistance with resolving this problem.

Code for that endpoint

app.post("/execute-command", async (c, next) => {
    try {
      const { command } = await c.req.json();
      if (!command) {
        return c.json({ error: "Command is required." }, 400);
      }

      // Execute the command using node-pty
      const term = pty.spawn(
        process.platform === "win32" ? "cmd.exe" : "bash",
        ["-c", command],
        {
          name: "xterm-256color",
          cols: 80,
          rows: 24,
          cwd: process.platform === "win32" ? undefined : process.env.HOME,
        }
      );

      const pattern = [
        "[\\u001B\\u009B][[\\]()#;?]*(?:(?:(?:(?:;[-a-zA-Z\\d\\/#&.:=?%@~_]+)*|[a-zA-Z\\d]+(?:;[-a-zA-Z\\d\\/#&.:=?%@~_]*)*)?\\u0007)",
        "(?:(?:\\d{1,4}(?:;\\d{0,4})*)?[\\dA-PR-TZcf-nq-uy=><~]))",
      ].join("|");
      const ansiRegex = new RegExp(pattern, undefined);
      const ansiRegex2 = new RegExp(pattern, "g");

      let output = "";

      // Listen for data events (output from the command)
      term.onData((data) => {
        output += data;
      });

      // Listen for the process to exit
      term.onExit(() => {
        console.log(output: ansiRegex.test(output)
            ? output.replace(ansiRegex2, "")
            : output)
        // Send the parsed output back to the client
        return c.json({
          output: ansiRegex.test(output)
            ? output.replace(ansiRegex2, "")
            : output,
        });
      });
      await next()
    } catch (error) {
      console.error(error);
      return c.json({ error: "Failed to execute command" }, 500);
    }
  });

[EdamAme-x]

What is the result you want when await next() is just execute?

[bajrangCoder]

I guess no
https://github.com/microsoft/node-pty/blob/d6ce76a801f68730f7204b7b27bb21dbf8e63001/typings/node-pty.d.ts#L147

[EdamAme-x]

If asynchronous, use await, declare a variable for the response in the scope of the handler, and assign it in the callback.
Ideally, finally the response variable should be returned.

[EdamAme-x]

Sounds like a synchronous function.
Then I'd just do the same thing without the await.

[bajrangCoder]

Ok got it 👍
Thanks 🙏

[EdamAme-x]

ty

[bajrangCoder]

If asynchronous, use await, declare a variable for the response in the scope of the handler, and assign it in the callback. Ideally, finally the response variable should be returned.

I have tried how you have mentioned but it returns the dispose function instead of the output

[EdamAme-x]

Perhaps you misunderstood the intent.
I came up with a solution.

How about wrapping it in a Promise object and resolving it when onExit is executed?

[EdamAme-x]

new Promise((resolve, reject) => {
...
term.onExit(() => {
...
resolve(result)
})
})

[bajrangCoder]

yeah, this promise method worked, Thanks