Fixing the miss due to which other class was not getting added to the very first article & that's the latest article was not listed #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… first index = 0 for any feed-newsroom block & that's why very first article was not listed
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
|
AFAIR we have to raise PR in https://github.com/sunstar-global/sunstar |
jindaliiita
reviewed
Jan 12, 2024
| @@ -6,7 +6,10 @@ export default async function decorate(block) { | |||
| others.classList.add('others'); | |||
| block.querySelectorAll(':scope > div').forEach((div, index) => { | |||
| if (index === 0) { | |||
There was a problem hiding this comment.
Simplified version
if (index === 0 && !hideSpotlight) {
spotlight = div;
} else {
div.classList.add('other');
others.appendChild(div);
}
sdmcraft
reviewed
Jan 12, 2024
There was a problem hiding this comment.
@meejain could you shift this PR against https://github.com/sunstar-global/sunstar
|
PR raised in sunstar global - sunstar-global#18. Hence closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… first index = 0 for any feed-newsroom block & that's why very first article was not listed
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after), along with a short summary of changes:
Issue
Fixes #557
Changelog:
Please enter each change as a new bullet point
Test URLs:
Library
New Blocks introduced in this PR
If yes, please provide details below
Block Name : For e.g. cards
Documented in sidekick library
New variations introduced in this PR
Variation Name : For e.g. cards (grid)
Documented in sidekick library
New mixins introduced in this PR
Mixin Name : For e.g. compact, white
Documented in sidekick library