Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Hotspot for research Page #556

Closed
wants to merge 4 commits into from
Closed

Implement Hotspot for research Page #556

wants to merge 4 commits into from

Conversation

meejain
Copy link

@meejain meejain commented Jan 11, 2024

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after), along with a short summary of changes:

Issue

Fixes #555

Changelog:

Please enter each change as a new bullet point

Test URLs:

Library

  • New Blocks introduced in this PR
    If yes, please provide details below
    Block Name : For e.g. cards

  • Documented in sidekick library

  • New variations introduced in this PR
    Variation Name : For e.g. cards (grid)

  • Documented in sidekick library

  • New mixins introduced in this PR
    Mixin Name : For e.g. compact, white

  • Documented in sidekick library

@meejain meejain self-assigned this Jan 11, 2024
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 11, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 11, 2024 •
edited
Loading

Page Scores Audits Google
/_drafts/meet/research PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

sdmcraft
sdmcraft reviewed Jan 12, 2024
View reviewed changes
Copy link

@sdmcraft sdmcraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
This section should only be visible in mobile view now that we have added the hotspot.

sdmcraft
sdmcraft reviewed Jan 12, 2024
View reviewed changes
Copy link

@sdmcraft sdmcraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hotspot on the original is visible only for width >= 992px . We should do the same. For smaller screens, the static image with accordian below it should be shown.

image

@jindaliiita
Copy link

AFAIR we have to raise PR in https://github.com/sunstar-global/sunstar

@meejain
Copy link
Author

meejain commented Jan 12, 2024

sunstar-global#20 created, taking care of all the above feedback. Closing this.

@meejain meejain closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdmcraft sdmcraft sdmcraft left review comments

@jindaliiita jindaliiita Awaiting requested review from jindaliiita

Assignees

@meejain meejain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Research Page > Map hover items
3 participants
@meejain @jindaliiita @sdmcraft