Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish strategy for CLS compliance #31

Closed
pglombardo opened this issue Feb 7, 2023 · 1 comment
Closed

Establish strategy for CLS compliance #31

pglombardo opened this issue Feb 7, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@pglombardo
Copy link
Collaborator

🚀 Feature Request

Because of the nature of the MQTT protocol, we make use of specific byte length and signed/unsigned variables that turn out to be non CLS compliant.

CLS compliance includes rules like:

Unsigned types should not be part of the public interface of the class.

The library uses UInt8, ushort and other similar types throughout. We likely have to do a full review to be CLS compliant.

📎 Additional context

@pglombardo pglombardo added the enhancement New feature or request label Feb 7, 2023
@pglombardo
Copy link
Collaborator Author

We are now CLS-compliant 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant