node-gyp breaks heroku deploys

[marcelosomers]

It looks like in late 2014 there were issues with the node-gyp repo and deploying to Heroku (#232). I've gone through all the threads and am still having the same issue when I push to Heroku. Here's the full output from when I git push heroku master

Here's my package.json:

"dependencies": {
  "hubot": "^2.16.0",
  "hubot-ambush": "0.0.3",
  "hubot-hipchat": "^2.12.0",
  "hubot-http-status": "^0.2.0",
  "hubot-motivate": "^3.0.0",
  "hubot-scripts": ">= 2.5.0 < 3.0.0",
  "hubot-seen": "^0.2.2",
  "hubot-standup-alarm": "0.0.3",
  "hubot-thank-you": "0.0.3",
  "hubot-trello": "^0.1.1"
},
"engines": {
  "node": "4.1.2",
  "npm": ">= 1.1.x"
}

The one thing I made sure to do was to use the official Heroku buildpack: heroku buildpacks:set https://github.com/heroku/heroku-buildpack-nodejs

Is there anything I'm doing wrong? These issues seem like they are so long ago that we shouldn't still be having them.

[cycomachead]

Are you sure it's node-gyp? It looks like iconv is where the install is breaking, and AFAIK, iconv isn't a depdency of hubot-hipchat, (or subdependency). Search through your node_modules to see what package is requiring iconv and try disabling it?

I may be wrong though...

[marcelosomers]

Looks like it's a nested dependency. hubot-hipchat -> node-xmpp-core -> ltx -> node-expat -> iconv.

I'm wondering if you'd be able to upgrade your required version of node-xmpp-core from 1.0.0-alpha14 which was released on March 5 to one of their newer releases which might fix the bug.

[marcelosomers]

FWIW, I forked it and bumped node-xmpp-core to v3.0.0 and it deployed fine. If you'd like, I can submit a PR, but I'm also not sure what other effects it might have.