Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to run action as a Docker image #22

Closed
rafaelschlatter opened this issue Sep 19, 2023 · 4 comments · Fixed by #23
Closed

Option to run action as a Docker image #22

rafaelschlatter opened this issue Sep 19, 2023 · 4 comments · Fixed by #23
Labels
enhancement New feature or request

Comments

@rafaelschlatter
Copy link

Hi @highbyte

What do you think of providing this action as a prebuild Docker image? I saw you have started on a GitHub action to create and publish a Docker image to a registry, but currently the action.yml points to the Dockerfile in the "runs" section.

Our experience is that building version 2.2.3 adds about 2 minutes to the run time of our GitHub actions. Using a prebuild version would be nice in order to save some build minutes.

@highbyte
Copy link
Owner

Hi,
Thanks for the feedback. It sounds like something that would be a good idea to implement, I'll look into it.

@highbyte highbyte added the enhancement New feature or request label Sep 19, 2023
@highbyte
Copy link
Owner

@rafaelschlatter There is now a pre-release version highbyte/[email protected] with a pre-built docker image. In my own workflows I've observed that the time for downloading the pre-built image is approx. half the time it took for building it (35 vs 77 seconds). Definitely a worthwhile change.

@highbyte highbyte linked a pull request Sep 21, 2023 that will close this issue
@highbyte highbyte removed a link to a pull request Sep 21, 2023
@highbyte highbyte linked a pull request Sep 21, 2023 that will close this issue
@rafaelschlatter
Copy link
Author

@rafaelschlatter There is now a pre-release version highbyte/[email protected] with a pre-built docker image. In my own workflows I've observed that the time for downloading the pre-built image is approx. half the time it took for building it (35 vs 77 seconds). Definitely a worthwhile change.

@highbyte in our first usages we saw a reduction of ca 90 secs (ca 2 min for building, vs ca 30 secs for pulling). Very much appreciated!

@highbyte
Copy link
Owner

@rafaelschlatter Thanks for the perf tip! Release version published as highbyte/[email protected] (no changes from beta)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants