Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change naming schema for the username and group #87

Open
majodev opened this issue Jul 23, 2018 · 2 comments
Open

change naming schema for the username and group #87

majodev opened this issue Jul 23, 2018 · 2 comments
Labels

Comments

@majodev
Copy link

majodev commented Jul 23, 2018

Hi,

It seems like naming a remote is subject to certain limitations as groupadd is executed (potentially 32chars?).

Example

apiVersion: gitkube.sh/v1alpha1
kind: Remote
metadata:
  name: app-remote
  namespace: my-really-really-really-long-ns
k logs po/gitkubed
Setting up git remotes
Configuring : my-really-really-really-long-ns-app-remote
Adding user `my-really-really-really-long-ns-app-remote' ...
Adding new group `my-really-really-really-long-ns-app-remote' (1000) ...
groupadd: 'my-really-really-really-long-ns-app-remote' is not a valid group name
adduser: `/usr/sbin/groupadd -g 1000 my-really-really-really-long-ns-app-remote' returned error code 3. Exiting.

Is there any way to overwrite the computed my-really-really-really-long-ns-app-remote identifier so groupadd can run through?

@tirumaraiselvan
Copy link
Collaborator

Yeah, I suppose there will be a problem with really long ns + remote names. Good catch. Maybe we can use some hash to represent (the user and groups) internally. I will send a fix soon.

@shahidhk shahidhk changed the title groupadd: Not a valid group name change naming schema for the username and group Oct 1, 2018
@sswastik02
Copy link

Hi @shahidhk,
Is this issue still valid ? If yes, I would like to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants