Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding secp256k1 support #7

Open
infinity0 opened this issue Mar 30, 2018 · 6 comments
Open

Adding secp256k1 support #7

infinity0 opened this issue Mar 30, 2018 · 6 comments

Comments

@infinity0
Copy link

lightning uses noise-with-secp256k1 even though this instantiation is not explicitly mentioned in the noise protocol spec.

Are there any plans to add this to cacophony, or would you be happy to accept a PR implementing such support?

@centromere
Copy link
Collaborator

I would accept a PR providing such support.

@ovangle
Copy link

ovangle commented May 2, 2018

Are you OK with secp256k1 from cryptonite lib? If so I could create a PR for that.

@centromere
Copy link
Collaborator

Yes. I am OK with that because it doesn't introduce an additional dependency.

@ysangkok
Copy link

ysangkok commented Sep 17, 2019

I have been working on this. We need to support the custom key rotation mechanism they use in Lightning, but if we do, it will work. I have a PR for secp256k1 support in Cryptonite, let's see if I can get that merged. If I can't, would you be ok with using the ECDH bindings that I could add to secp256k1-haskell? That would require one new dependency then.

@centromere
Copy link
Collaborator

Yes.

@ysangkok
Copy link

See PR #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants