Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onEvict callback for ARC #22

Open
olebedev opened this issue Dec 22, 2015 · 8 comments
Open

onEvict callback for ARC #22

olebedev opened this issue Dec 22, 2015 · 8 comments

Comments

@olebedev
Copy link

Hi, I would like to say thanks for this project guys.

Is there any plans to add onEvict callback to ARC cache too? Actually, it's pretty useful when you work with sync.Pool as well.
@yonderblue
Copy link

+1 here

@vtolstov
Copy link

Also +1 and if that possible onEvict for TwoQueueCache

@vtolstov
Copy link

any news from devs? or package is drop down and not needed for hashicorp?

@sean-
Copy link
Contributor

sean- commented Dec 15, 2017

I had a need for this same functionality and added support to it in https://github.com/bluele/gcache , FYI.

@vtolstov
Copy link

Thanks, i'm switch package =)

@jefferai
Copy link
Member

@sean- could have added it here instead :-)

@sean-
Copy link
Contributor

sean- commented Dec 16, 2017

Heh. I started with this LRU implementation and moved to the other because it had some of the primitives I immediately needed.

https://github.com/joyent/pg_prefaulter/blob/master/agent/fhcache/cache.go#L61-L95

@jasonsurratt jasonsurratt mentioned this issue Aug 28, 2018
Closed
@jasonsurratt
Copy link

I've added a draft PR for the evict functionality. #48

Feedback is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jefferai @sean- @vtolstov @olebedev @yonderblue @jasonsurratt