Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research Etherscan & BlockScout APIs to confirm priority list offering #3324

Open
1 of 2 tasks
Tracked by #3314
konstantinabl opened this issue Dec 10, 2024 · 1 comment
Open
1 of 2 tasks
Tracked by #3314
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@konstantinabl
Copy link
Collaborator

konstantinabl commented Dec 10, 2024

** Description **

Research possibilities for implementation for the endpoint mentioned in the main description of the EPIC

Tasks

Preview Give feedback
@konstantinabl
Copy link
Collaborator Author

konstantinabl commented Dec 17, 2024

Etherscan findings:

  1. https://docs.etherscan.io/api-endpoints/blocks#get-block-and-uncle-rewards-by-blockno - no point in implementing this, since in Hedera there are no concept of uncles or block rewards
  2. https://docs.etherscan.io/api-endpoints/accounts#get-a-list-of-erc721-token-transfer-events-by-address - can be easily implemented using the contract/logs endpoint in the MN API. Need to identify erc721 tokens by using the new ERC Registry or sevm lib.
  3. https://docs.etherscan.io/api-endpoints/accounts#get-a-list-of-erc1155-token-transfer-events-by-address - same as above with the only difference identifying 1155 contracts may not be so straightforwards

Blockscout findings:

  1. https://docs.blockscout.com/devs/apis/rpc/block#get-block-reward-by-block-number - again not applicable
  2. https://docs.blockscout.com/devs/apis/rpc/account#get-token-transfer-events-by-address - imo this endpoint is similar to this in etherscan https://docs.etherscan.io/api-endpoints/accounts#get-a-list-of-erc20-token-transfer-events-by-address and thus it is possible to implement it in a similar way to the erc721 transfer list
  3. https://docs.blockscout.com/devs/apis/rpc/account#get-list-of-tokens-owned-by-address - i believe this would be very hard to implement. Blockscout are using a DB, so its easy for them to display this info. For us however, its more complicated since balances of erc-20 tokens are stored in the contract itself, meaning we need to either track all transfers into an account and somehow calculate what went out and what went in OR scan all erc-20s, call erc20.balanceOf(). All of this is very expensive and may not be worth it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Tasks In Progress
Development

No branches or pull requests

1 participant