Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiHeadedAttention: affine transforms #95

Open
axelbr opened this issue Jun 8, 2022 · 0 comments
Open

MultiHeadedAttention: affine transforms #95

axelbr opened this issue Jun 8, 2022 · 0 comments

Comments

@axelbr
Copy link

axelbr commented Jun 8, 2022

First of all: thank you for this work, it is really easy to follow along this notebook.

My question is the following:
In the MultiHeadedAttention class, you instantiate 4 affine layers instead of 4 linear ones (bias is True by default). Is this on purpose? Then the text should be updated, as there are only the 4 matrices mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant