Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pipe_id to identify client may not be safe #3

Open
zacharied opened this issue Jul 22, 2020 · 0 comments
Open

Using pipe_id to identify client may not be safe #3

zacharied opened this issue Jul 22, 2020 · 0 comments
Assignees

Comments

@zacharied
Copy link
Collaborator

zacharied commented Jul 22, 2020

We currently use nng_pipe_id() to figure out the source of a message. But if the pipe_id is something that is written by the nng client library, then a tenant can totally just spoof their own client ID. My intuition tells me that it's probably set up like that.

Solutions:

  • Have an individual named pipe for each tenant
  • Give client a secret token when they first connect, and require that token with all future requests
@zacharied zacharied self-assigned this Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant