-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data download is completely broken by CMC's v1 API Deprecation #86
Comments
Found same error |
Found same error too EDIT: But couldn't find the map endpoint to get the id to get the data |
yes same issue |
same issue here |
I think you can get the map endpoint with a basic (free) API key. My code relies on it currently. Where did you find the docs for this endpoint you've referenced? |
Yes you're right and I think for this package to work it would need an endpoint without API key. |
This is a(n):
Details:
CoinMarketCap (CMC) seems to have recently deprecated some of their V1 endpoints, which this library depends on.
In
utils.py
we have the core downloading logic accessing the following endpoints:CMC now requires an API key for this, and gives a different response than the code downstream in
core.py
's_download_data
method expects:Error message (download_data) : Expecting value: line 1 column 1 (char 0)
Unless I'm completely wrong, CMC's API change may make this library completely obsolete, which is sad.
The text was updated successfully, but these errors were encountered: