Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csurf deprecation #2790

Open
ob6160 opened this issue Jul 3, 2024 · 1 comment · May be fixed by #3010
Open

csurf deprecation #2790

ob6160 opened this issue Jul 3, 2024 · 1 comment · May be fixed by #3010

Comments

@ob6160
Copy link
Contributor

ob6160 commented Jul 3, 2024

👋 It looks like the csurf package used for CSRF protection:

import csrf from 'csurf';
is deprecated which could be a potential risk (albeit, a small one).

Perhaps a package could be avoided completely here?

(came across this as I was using GW as a reference for csrf implementation elsewhere 😄 )

@coldlink
Copy link
Member

coldlink commented Jul 8, 2024

Thanks! Yeah we're already aware of this. The risk is fairly low thankfully, but we're planning on making our own implementation when we get time, specifically the Signed Double-Submit Cookie method (which is the method we're already using with the current library).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants