Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a settings button to the editor #2432

Open
4 tasks done
wshoy opened this issue Oct 3, 2024 · 5 comments
Open
4 tasks done

Add a settings button to the editor #2432

wshoy opened this issue Oct 3, 2024 · 5 comments

Comments

@wshoy
Copy link
Contributor

wshoy commented Oct 3, 2024

⚠️ This issue respects the following points: ⚠️

  • This is a enhancement/feature request. Not a bug or question.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The wanted feature/enhancement is not present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor's settings are not touched. If your desired feature is present, you don't need to open this issue. The change will be part of the next Markor update.)

Description

Settings can't be reached when opening just the editor (if you click on the ToDo widget for example).
The settings button in the editor it should lead to its own format settings.

Information

Android version: 14
Device:
App Version: 2.12.5

Source

F-Droid

Format / File type

Not specific

Additional info / Log

-
@gsantner
Copy link
Owner

gsantner commented Oct 3, 2024

The settings button in the editor it should lead to its own format settings.

Disagree for sure about that part. The settings specific to format are rather small amount, so the overall settings are more of help.

@wshoy
Copy link
Contributor Author

wshoy commented Oct 3, 2024

Ok, that's true.

@wshoy wshoy changed the title Add "Format" settings button to the editor Add a settings button to the editor Oct 3, 2024
@harshad1
Copy link
Collaborator

harshad1 commented Oct 3, 2024

What settings are you changing frequently?

@wshoy
Copy link
Contributor Author

wshoy commented Oct 6, 2024

What settings are you changing frequently?

Mostly action order. I can't do that without exiting.

I also saw some other small potential improvements in settings:

  • Not all text in settings is visible. There is a "Disable highlighting for code blocks" option that appears as "Disable highlighting for co..".
  • The "Editor" options from "Other" probably should be moved to the "Editor mode"
  • The default highlighting delay seems a bit too long. I have found 350ms instead of 650ms to be optimal. Is the performance still an issue after 6+ years? It also goes up to 5000ms which might be a little excessive.
  • The "Dynamic highlighting" checkbox could be made to be disabled when unchecking "Syntax highlighting".

@gsantner
Copy link
Owner

gsantner commented Oct 6, 2024

Only to that part

Is the performance still an issue after 6+ years

Yes. Markor still works on old devices. And (old) devices with weak hardware have still weak hardware. Also higher rate means higher battery usage. That settings needs very careful selected default value. Overall yes Markor got performance/efficient improvements, but still shouldnt be scanning the whole time.

Might be slightly adjustable, but not too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants