Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoplay is permanently on #260

Open
francisashley opened this issue Oct 27, 2022 · 0 comments
Open

Autoplay is permanently on #260

francisashley opened this issue Oct 27, 2022 · 0 comments

Comments

@francisashley
Copy link

francisashley commented Oct 27, 2022

if (this.autoPlay) {

This expression is checking if the internal autoPlay method exists (always truthy) when it should be checking this.autoplay.

This line of code is making the package fundamentally unstable.

@kyuwoo-choi PR #210 was created for this a year ago,

could we please get this merged.

@francisashley francisashley changed the title [❗️❗️❗️] Autoplay is permanently on Autoplay is permanently on Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant