Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Tag Manager #51

Open
a108167 opened this issue Mar 5, 2021 · 2 comments
Open

Add Google Tag Manager #51

a108167 opened this issue Mar 5, 2021 · 2 comments

Comments

@a108167
Copy link

a108167 commented Mar 5, 2021

I would like to extend this theme to include Google Tag Manager and I'd like to mirror how mkdocs-material did it:
squidfunk/mkdocs-material#2055
Before I submit a PR I wanted to confirm that this repo was still being actively monitored. Thanks.

@dsagal
Copy link
Member

dsagal commented Mar 5, 2021

To be honest, I've been working with major overrides of the theme that have diverged in a big way, in particular because of issues in getting pages indexed by search engines (the funky redirections may not have been a great idea).

So the version here has gotten no attention for some time. I could push my changes into a branch, if there is interest in a potential v2 of this theme. But also no objections to a Google Tag Manager support to add to this version.

@a108167
Copy link
Author

a108167 commented Mar 5, 2021

If v2 is inevitable then it would probably make sense to add it in that one. Can you push it into a branch but also let me know your thoughts on timelines, etc? I can then decide if I would like to implement it in v1 or wait.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@dsagal @a108167 and others