Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO #6

Open
victorsndvg opened this issue Jun 11, 2020 · 1 comment
Open

TODO #6

victorsndvg opened this issue Jun 11, 2020 · 1 comment

Comments

@victorsndvg
Copy link
Contributor

victorsndvg commented Jun 11, 2020

Current implementation is almost done, but some details are still pending:

  1. Increase coverage/tests/examples to stress bindings as much as possible
  2. test/example_3.jl: replace malloc/free by julia array
  3. P4est_jll integration: Currently, this bindings only supports the parallel version of p4est. P4est_jlll artifact contains a non-MPI version. I think the main difference between both is the MPI_Comm representation, Ptr{Cvoid} (8 bytes) for parallel version, Cint(?) (4 bytes) for sequential version. We should deal with this difference during package build.
@victorsndvg
Copy link
Contributor Author

victorsndvg commented Jun 11, 2020

  1. still pending
  2. Done in 5a013ee
  3. implemented in ce5023b . A new variable P4EST_ENABLE_MPI is set during build (manually from ENV or with a default value). MPI_Comm datatype changes depending on its value. P4est_jll case is correctly managed. Tests are also adapted to exemplify its usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant