Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update static list of filaments to be loaded from Bambu API endpoint at runtime instead. #753

Open
AdrianGarside opened this issue Nov 17, 2024 · 7 comments
Labels
feature request New feature or request

Comments

@AdrianGarside
Copy link
Collaborator

Describe the feature

Can fallback to the static list if that fails.

What device is this for?

A1

Other Information

No response

@AdrianGarside AdrianGarside added the feature request New feature or request label Nov 17, 2024
@AdrianGarside
Copy link
Collaborator Author

Can also do the same for HMS / AMS and PRINT errors.

@greghesp
Copy link
Owner

It might be better here to write a GitHub action that will call an API on a new release, which updates the files in the repo. I'm not sure though if you can have an action that does this in between a release getting created.

@t3chguy
Copy link
Contributor

t3chguy commented Nov 19, 2024

I'm not sure though if you can have an action that does this in between a release getting created.

You can't really, the release happens too late, you can create an automation to do the updating then create the release for you, but then changelogs become a pain. I've invested a lot of work time in a sane workflow which automatically maintains draft releases using https://github.com/release-drafter/release-drafter then to publish such a release you would use a workflow_dispatch github action to do the release, e.g.

image

Where the draft release accumulates all changes via generated changelogs and you can edit the draft to add any manual notes, I did a release earlier today so there is nothing new to release. The draft is only visible to the maintainers. The version is automatically bumped based on semver rules if desirable.

image

@greghesp
Copy link
Owner

Hmmm @AdrianGarside - thoughts?

Not sure how often the HMS errors get updated? Might just be easier to have them run once a month or something

@t3chguy
Copy link
Contributor

t3chguy commented Nov 19, 2024

Yeah what I'd suggest here is akin to https://github.com/element-hq/element-web/blob/develop/.github/workflows/update-jitsi.yml which makes a PR periodically only if there are changes to commit

@AdrianGarside
Copy link
Collaborator Author

They won’t change much so I’ll just update the existing script to put the localized content directly into the translation files and kill off the live lookup I just added since I can’t get the viewing users language.

@AdrianGarside
Copy link
Collaborator Author

For the known filaments I think I will stick with a live lookup with a fallback to the checked in list so we’re not a bottleneck as new filaments get added which is likely more frequently than new HMS errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants