-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Update static list of filaments to be loaded from Bambu API endpoint at runtime instead. #753
Comments
Can also do the same for HMS / AMS and PRINT errors. |
It might be better here to write a GitHub action that will call an API on a new release, which updates the files in the repo. I'm not sure though if you can have an action that does this in between a release getting created. |
You can't really, the release happens too late, you can create an automation to do the updating then create the release for you, but then changelogs become a pain. I've invested a lot of work time in a sane workflow which automatically maintains draft releases using https://github.com/release-drafter/release-drafter then to publish such a release you would use a workflow_dispatch github action to do the release, e.g. Where the draft release accumulates all changes via generated changelogs and you can edit the draft to add any manual notes, I did a release earlier today so there is nothing new to release. The draft is only visible to the maintainers. The version is automatically bumped based on semver rules if desirable. |
Hmmm @AdrianGarside - thoughts? Not sure how often the HMS errors get updated? Might just be easier to have them run once a month or something |
Yeah what I'd suggest here is akin to https://github.com/element-hq/element-web/blob/develop/.github/workflows/update-jitsi.yml which makes a PR periodically only if there are changes to commit |
They won’t change much so I’ll just update the existing script to put the localized content directly into the translation files and kill off the live lookup I just added since I can’t get the viewing users language. |
For the known filaments I think I will stick with a live lookup with a fallback to the checked in list so we’re not a bottleneck as new filaments get added which is likely more frequently than new HMS errors. |
Describe the feature
Can fallback to the static list if that fails.
What device is this for?
A1
Other Information
No response
The text was updated successfully, but these errors were encountered: