Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] With latest P1P firmware we're sending a cancelled event followed by a failed event #257

Open
AdrianGarside opened this issue Oct 21, 2023 · 4 comments
Assignees
Labels
bug Something isn't working no-issue-activity

Comments

@AdrianGarside
Copy link
Collaborator

Describe the bug

The latest P1P firmware adjusted the missing failed state. So now a cancel presents as a transient cancel state and then a persistent failed state. So I'm firing both events one after another.

To Reproduce

.

Expected Behaviour

.

What device are you using?

X1C

Diagnostic Output

.

Log Extracts

No response

Other Information

No response

@AdrianGarside AdrianGarside added the bug Something isn't working label Oct 21, 2023
@AdrianGarside AdrianGarside self-assigned this Oct 21, 2023
Copy link

Stale issue message

@AdrianGarside
Copy link
Collaborator Author

X1C we get failed then cancelled but maybe that's the order I search for the states since it appears they came in a single payload:
2023-12-24 15:00:59.519 DEBUG (Thread-2 (mqtt_listen_thread)) [custom_components.bambu_lab.pybambu] Received data from: X1C
2023-12-24 15:00:59.519 DEBUG (Thread-2 (mqtt_listen_thread)) [custom_components.bambu_lab] EVENT: event_print_failed: {'device_id': '92be1c12489f8dbd568d9fdf9f920ef4', 'type': 'event_print_failed'}
2023-12-24 15:00:59.519 DEBUG (Thread-2 (mqtt_listen_thread)) [custom_components.bambu_lab] EVENT: event_print_canceled: {'device_id': '92be1c12489f8dbd568d9fdf9f920ef4', 'type': 'event_print_canceled'}

@AdrianGarside
Copy link
Collaborator Author

Yes, we check for print failed first then canceled. Need to swap so we can only fire the canceled event. On X1 at least.

Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity
Projects
None yet
Development

No branches or pull requests

1 participant