Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinctive rendering for building=construction #4164

Open
maro-21 opened this issue Jun 17, 2020 · 6 comments
Open

Distinctive rendering for building=construction #4164

maro-21 opened this issue Jun 17, 2020 · 6 comments
Labels
buildings new features Requests to render new features

Comments

@maro-21
Copy link

maro-21 commented Jun 17, 2020

How about rendering building=construction in a different color? For example a lighter shade of gray, or with an edge in a different color.

@HolgerJeromin
Copy link
Contributor

ref #2532

@jeisenbe jeisenbe added new features Requests to render new features buildings labels Jun 18, 2020
@jeisenbe jeisenbe changed the title different color for building=construction Different color for building=construction Jun 18, 2020
@jeisenbe jeisenbe changed the title Different color for building=construction Distinctive rendering for building=construction Jun 18, 2020
@jeisenbe
Copy link
Collaborator

I've changed the title to "Distinctive rendering for building=construction" to more clearly state the requested new feature.

Currently buildings under construction are rendered the same as all other buildings if they are tagged as building=construction. Using a lifecycle prefix like construction:building=* leds to no rendering of the feature.

We could consider adding a distinctive rendering for the established tag building=construction, if anyone has a good idea about how it could look.

@polarbearing
Copy link
Contributor

We have a very distinctive rendering for landuse=construction, which usually surrounds the constructed building. Do we need a distinction for the building itself then?

@maro-21
Copy link
Author

maro-21 commented Jun 18, 2020

We have a very distinctive rendering for landuse=construction, which usually surrounds the constructed building. Do we need a distinction for the building itself then?

There may be situations when there is no construction site around and the building is not finished, sometimes for many years.

@Adamant36
Copy link
Contributor

I don't think it would be good to render building=construction in a unique way. Even if it has the usage numbers. A house is still a house even if it's not completely done being built yet and "construction" isn't really a building type. Is it more important that map consumers know a plot of land has a house on it? or that there is a general, undefined, type of undefined building that renders a certain way because the carpeting isn't done being stapled?

Also, it's not really clear when construction is over and a different building tag should be used instead. Many hotels are in an almost constant state re-modeling/construction/renovation. So should the whole place be rendered or tagged differently because of it while other parts of the hotel are still being used as a hotel? Again, does it serve map consumers more to know that the place is a hotel or some "under construction" building? What's the threshold before it isn't under construction anymore?

Those issues aren't really present with landuse=construction IMO. It's pretty clear when a construction zone is gone and it is more of an actual type of landuse then "construction" is a type of building.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 1, 2020

This is a well-established tag, used over 0.5 million times. Generally it is used for buildings that are not yet finished and cannot be used, because they lack complete walls or roofs, so are clearly construction sites. This makes it a verifiable tag. While this state is usually temporary, construction can take years.

It is worth considering rendering these, because a building under construction might not qualify as a building= feature normally, due to incomplete walls and roof.

(Similarly, building=roof would be the other tag that would most benefit from a distinctive rendering, since walls are lacking).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buildings new features Requests to render new features
Projects
None yet
Development

No branches or pull requests

5 participants