-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering for wall=no #2623
Comments
wall=no + building=yes to denote a one-sided open shed? Honestly, I really think this kind of stuff simply classifies as building=shed, and should have been tagged and imported as such by the french community (there are some wacko import taggings in the Netherlands where I live too by the way... ). The fact that the shed is open on one side, could have been tagged differently and more logical and explicit than this. Maybe open_sided=yes as supplement to the documented building=shed tag that is used world wide instead of just in France? |
I also think |
Even more reason to tag with building=shed is that most of these are probably firewood sheds: which seem to be called like that in English, considering the above Google search... Maybe another tagging could be: |
At least in France, wall=no + building=yes can either refer to one of these: Part of a building (on the right side here): I don't know the history about this choice, but if you think it's misused or could be done better, I'll ask upstream :). edit: @mboeringa most of these are not building=shed actually, but much more the first image I shown (subpart of a building). |
Yes, I think that is wise to do... ;-) The first picture seems to me nothing but a luxury version of building=shed, while the second is clearly building=roof. If no distinction can be made based on the imported stuff, I guess building=shed is the most logical choice to re-tag them, as building=roof is more often used and associated with bigger structures like roofs on railway or petrol stations, and mostly not used for storage, like a shed and the second picture shown at the bottom. |
2017-05-01 16:50 GMT+02:00 mboeringa <[email protected]>:
The first picture seems to me nothing but a luxury version of
*building=shed*, while the second is clearly *building=roof*. If no
distinction can be made, I guess *building=shed* is the most logical
choice to re-tag them, as *building=roof* is more often used and
associated with bigger structures like roofs on railway or petrol stations,
and not used for storage, like a shed.
+1, there is documentation for wall=* as a subtag for barrier=wall, where
wall is used to provide details about the wall, even the French version
doesn't mention "no" as value (although it is very common due to your
import). https://wiki.openstreetmap.org/wiki/Key:wall
I would agree with building=* and wall=no being a synonym for a
building=roof with no walls, but in the case of at least one wall it seems
wrong (no is no, not?)
|
Just to be clear and ensure that we all are on the same page. So I don't think any |
I really think rendering of this tag is a dead end. I think the French community should reconsider what they want to do with this information:
Personally, I'd go for 3)... The particular wildly varying mixture of buildings and structures you are showing for a "light" building, also strongly points in the need to enhance tagging using more appropriate tags and field observations. |
On 6. Jun 2017, at 22:27, mboeringa ***@***.***> wrote:
Start enhancing the data by classifying it using more useful tags by field or imagery observation
+1, just because the cadastre didn't provide more building detail doesn't mean France has to remain at that level, you can always improve this first version with more precise tagging from survey
|
Yes obviously that's what we must target. But in the mean time should we just ignore this information? Why rendering |
Just to remember: osm-carto does not render any light buildings different #2532 then building=yes. But this style is (also) a mapper feedback loop not (only) to have a nice looking map. If osm-carto would render french-light building special who would stand up and clean up the import? |
I am not convinced that supporting and encouraging this tag is a wise choice. If light/minor/shedlike building are to be rendered differently I think that building=* value should be used. I plan on closing it per @mboeringa comments. |
wall=no
should be used forslight construction like a shed or balcony opened on one side at least or without foundation
(wiki). It is mainly used in France due to cadastre import:In OSM French style, it is rendered with lower opacity starting at zoom 18:
The text was updated successfully, but these errors were encountered: