Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering of building=train_station and railway=platform/highway=platform(?) does not respect layers #2504

Closed
jc86035 opened this issue Dec 11, 2016 · 8 comments

Comments

@jc86035
Copy link

jc86035 commented Dec 11, 2016

See 22.4482°N, 114.0046°E. The small light rail platforms (1, 2 and 3 to the northeast) should ideally be rendered below the large train station building (or in a tunnel casing, if possible), and the train platforms (and station building) should all be rendered above the road junction. However, currently all are rendered below the road, and platforms do not change rendering with tunnel=yes/covered=yes.

In addition, the new brown rendering of building=train_station is being a little annoying. Although the "station building" is underground, the brown is rendered above the buildings located over the station. I know the solution in this particular case is probably to change the station to pedestrian passageways + platforms with a railway=station node, but the brown casing could instead be made transparent.

@kocio-pl
Copy link
Collaborator

It's quite old and known problem - see especially #688 and #327.

The general problem with layers is that we don't have "universal" layers. They work only inside the single class of objects and it's a designer decision to make some classes be located on top of some others.

However I'm curious now if we could make a special, separate layer just for train stations and make it located above all the roads and platforms. This exception could be compromise worth having, because train stations in big cities should be visible as landmarks and we're not able to show their inner structure in a usable way without layer viewer, so they tend to suffer the most:

Berlin - http://www.openstreetmap.org/node/3856100103
New York - https://www.openstreetmap.org/way/265947358
Paris - http://www.openstreetmap.org/way/67825345
London - http://www.openstreetmap.org/relation/6036811
Warsaw - http://www.openstreetmap.org/way/367491792

@geozeisig
Copy link

geozeisig commented Dec 12, 2016

They work only inside the single class of objects and...

It does not even work with the platforms. In the case of the Berlin example, the upper platform merges with the lower platform. It should be recognizable by a margin who lies over whom.

@mboeringa
Copy link

mboeringa commented Dec 12, 2016

In the case of the Berlin example, the upper platform merges with the lower platform. It should be recognizable by a margin who lies over whom.

Just for your information: even if a style would support rendering platforms in a layered fashion (which isn't trivial to implement), the Berlin example would fail, as the platforms are only tagged with level=x, not layer=x:

http://www.openstreetmap.org/relation/929443#map=18/52.52444/13.36871

I also think it would be wise to remove the name of the railway station from the platforms. It duplicates information that is already on the station relation. A platform rarely has a name, just a ref.

@jc86035 jc86035 changed the title Rendering of building=railway_station and railway=platform/highway=platform(?) does not respect layers Rendering of building=train_station and railway=platform/highway=platform(?) does not respect layers Apr 23, 2017
@jc86035
Copy link
Author

jc86035 commented Apr 25, 2017

Could building=train_station be rendered with the same layering as other buildings? There are several (above-ground) railway stations which have taller structures above them, and the brown obscures the other buildings.

@nebulon42
Copy link
Contributor

@jc86035 Could you provide links to examples of what you mean?

@dieterdreist
Copy link

dieterdreist commented Apr 30, 2017 via email

@Gazer75
Copy link

Gazer75 commented Jun 3, 2017

building=roof + layer=1 really should be above a platform, but that is not working currently.

@jc86035
Copy link
Author

jc86035 commented Apr 11, 2019

At some point building=train_station started being layered correctly (this could be a side effect of #3426), and covered platforms are now also being hidden (even if I think it probably have been better to give them some sort of tunnel casing). As such, the issue has been completely resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants