Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flame graph view: (auto)refreshing should preserve UI context #260

Open
grafakus opened this issue Nov 5, 2024 · 2 comments · May be fixed by #325 or grafana/grafana#98356
Open

Flame graph view: (auto)refreshing should preserve UI context #260

grafakus opened this issue Nov 5, 2024 · 2 comments · May be fixed by #325 or grafana/grafana#98356
Assignees
@grafakus
Labels
bug Something isn't working 🔥 flamegraph package GA

Comments

@grafakus
Copy link
Contributor

grafakus commented Nov 5, 2024 •
edited
Loading

Bug description

  • Grafana version: 11.3.0
  • Plugin version: 0.1.15

Steps to reproduce

  1. Go to this URL: playground
  2. Click on a node of the flame graph
  3. Select "Focus block"
  4. Click on the refresh button next to the main time picker

Actual behaviour

The flame graph completely re-renders, exits the focus mode to display the new data

Expected behaviour

The flame graph should not completely re-render but stay in focus mode and update only the relevant values

The same happens with:

  • The sandwich view
  • The function details panel
  • The AI panel
  • After selecting an auto-refresh period
@grafakus grafakus added the bug Something isn't working label Nov 5, 2024
@grafakus
Copy link
Contributor Author

grafakus commented Nov 5, 2024

Slack context, cc @marctc

@grafakus grafakus self-assigned this Dec 17, 2024
@grafakus grafakus linked a pull request Dec 19, 2024 that will close this issue
Open
@grafakus
Copy link
Contributor Author

Here's a PR to improve the "Focus block" & "Sandwich view" scenarios: #325

@grafakus grafakus changed the title [bug] Flame graph view: (auto)refreshing should preserve UI context Flame graph view: (auto)refreshing should preserve UI context Dec 23, 2024
@grafakus grafakus linked a pull request Dec 23, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grafakus grafakus

Labels
bug Something isn't working 🔥 flamegraph package GA
Projects
None yet
Milestone
No milestone
1 participant
@grafakus