Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBV_EXP_PEER_OP_POLL_NOR_DWORD_CAP not working correctly #7

Open
drossetti opened this issue Jun 7, 2018 · 1 comment
Open

IBV_EXP_PEER_OP_POLL_NOR_DWORD_CAP not working correctly #7

drossetti opened this issue Jun 7, 2018 · 1 comment

Comments

@drossetti
Copy link
Contributor

drossetti commented Jun 7, 2018

@haggaie @ferasd
@e-ago FYI
On Volta arch GPUs, CU_STREAM_WAIT_VALUE_NOR is available.
Therefore we can enable IBV_EXP_PEER_OP_POLL_NOR_DWORD_CAP.
When testing its use in libgdsync, we noticed gpudirect/libgdsync#68.

We tracked it down to mlx5_alloc_cq_buf non properly setting the owner bit to 1. Currently fixed as below:

        for (i = 0; i < nent; ++i) {
                cqe = buf->buf + i * cqe_sz;
                cqe += cqe_sz == 128 ? 1 : 0;
                cqe->op_own = MLX5_CQE_INVALID << 4;
                if (cq->peer_ctx && (cq->peer_ctx->caps & IBV_EXP_PEER_OP_POLL_NOR_DWORD_CAP)) {
                        cqe->op_own |= MLX5_CQE_OWNER_MASK;
                }

Not sure if more fixes are needed elsewhere, e.g. mlx5_cq_resize_copy_cqes

@drossetti
Copy link
Contributor Author

At the moment, we keep the NOR feature disabled by default in libgdsync.
We would need a way to detected a fixed MLNX OFED and enable the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant