Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll back up button #377

Open
Ainali opened this issue Apr 16, 2024 · 10 comments · May be fixed by #381
Open

Scroll back up button #377

Ainali opened this issue Apr 16, 2024 · 10 comments · May be fixed by #381
Labels
enhancement 🥇 New feature or request

Comments

@Ainali
Copy link
Member

Ainali commented Apr 16, 2024

The feature

As some of our pages are really long, especially country pages, it would be nice with a button that brings you back to the top on those.

Why?

It could save time and also increase accessibility somewhat. Also, implemented right it looks kind of cool.

Examples and inspiration

I stumbled upon this neat and dynamic solution using only CSS:

It shows the button only after have started scrolling down a bit. For us, it could be when you have scrolled past the country info box.
@Ainali Ainali added the enhancement 🥇 New feature or request label Apr 16, 2024
Ainali added a commit that referenced this issue May 3, 2024
@Ainali
💄 Add back-to-top link
f7fb83f 
Based on https://codepen.io/chriscoyier/pen/NWmzZXo

Fixes #377
@Ainali Ainali linked a pull request May 3, 2024 that will close this issue
Open
@MarcosApodaca
Copy link

I'm interested in adding this work to your website, I'm open to be assigned the case and I would be happy to solve it.

@Ainali
Copy link
Member Author

Ainali commented May 5, 2024

I'm interested in adding this work to your website, I'm open to be assigned the case and I would be happy to solve it.

@MarcosApodaca: There is already a PR for this issue (linked just above your comment). Your review on that one is welcome.

@MarcosApodaca
Copy link

I saw it, but in the web it is not implemented yet, enter in the section of countries, and when you scroll the names, the scroll does not appear to take you to the top of the page.

@RVA2869
Copy link
Collaborator

RVA2869 commented May 5, 2024

but in the web it is not implemented yet

@MarcosApodaca
Because the PR has not yet been merged with the main branch....

@Ainali
Copy link
Member Author

Ainali commented May 5, 2024

@MarcosApodaca As RVA2869 said, it hasn't been merged yet. Which means that this is a great opportunity for you to set up your local environment, and switch to that branch and see if it works locally for you. That will give you a flying start for another issue too.

Ainali added a commit that referenced this issue May 14, 2024
@Ainali
💄 Add back-to-top link
311fb94 
Based on https://codepen.io/chriscoyier/pen/NWmzZXo

Fixes #377
@Abbe98
Copy link
Member

Abbe98 commented May 21, 2024

As someone who runs desktop Firefox on my phone, is this for other mobile browsers which do not have this builtin nowadays?

@Ainali
Copy link
Member Author

Ainali commented May 21, 2024

As someone who runs desktop Firefox on my phone, is this for other mobile browsers which do not have this builtin nowadays?

I was mostly thinking about this as a desktop feature.

But now that I tried it on Firefox on my phone, I don't see anything like this. Is it not enabled by default?

@Abbe98
Copy link
Member

Abbe98 commented May 22, 2024 •
edited
Loading

But now that I tried it on Firefox on my phone, I don't see anything like this. Is it not enabled by default?

I'm not sure about Android and iOS browsers. Edit, on iOS you just press the statusbar.

On desktop I think "all" browsers support pressing <home>, and in many you can just click the active tab.

@Ainali
Copy link
Member Author

Ainali commented May 24, 2024

On desktop I think "all" browsers support pressing <home>, and in many you can just click the active tab.

Clicking the active tab does nothing on Firefox or Chrome on desktop for me. The home button works, but is a two-hand combination on my laptop keyboard (need to be combined with Fn (function)), so I need to let go of the mouse to use it.

@Abbe98
Copy link
Member

Abbe98 commented May 25, 2024

I'm convinced, on Android does accelerated scroll work and if so should we hide it on mobile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🥇 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add back-to-top link govdirectory/website
4 participants
@Abbe98 @Ainali @MarcosApodaca @RVA2869