-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Testing support? #41
Comments
Great suggestion! @kentcdodds actually created some for this repo + the node repo over at https://github.com/kentcdodds/testing-workshop. Maybe we could convince him to make a PR back here at some point :) 🙏 |
That would be great :) |
Perhaps! Though I did make a number of changes to make the code more testable. 🙃 |
In that case, we'd love to have those changes PR'd 🙌😄 |
I'm sure! It's unlikely I'll get around to it, but maybe someone who takes the workshop will be inspired :) |
@EricSimons I wrote some unit tests and changed a little bit of code to be more clean, i would love to write a full test suite for this, should i pr the initial tests so you see if they are okay before moving on? |
@justDanielMata yes absolutely!! 🙌 |
@EricSimons i'm probably dumb, but it is the first time i create a pull request for an oss project, how do i create the pr? it says i'm inauthorized on my terminal. |
@justDanielMata github actually has a button in the UI that will automatically do that PR for you — where is your current forked repo located? |
Oh maybe that is the issue, i cloned the repo, didn't fork it, i'm trying
to submit a pr pushing from my terminal, should i fork it?
2017-06-06 18:18 GMT-03:00 Eric Simons <[email protected]>:
… @justDanielMata <https://github.com/justdanielmata> github actually has a
button in the UI that will automatically do that PR for you — where is your
current forked repo located?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATF0gbf-Xb8ChBdG41bEyCvHvqBY0bGqks5sBcI7gaJpZM4NFhsS>
.
|
Yup! Heres some more info on how to do it: https://stackoverflow.com/questions/14680711/how-to-do-a-github-pull-request |
Is the effort on adding tests still going on? |
Hi, Thank you for the project, I really like the idea.
I use React + Redux for about a year however I don't feel very comfortable with testing.
Are tests going to be implemented?
Thanks
The text was updated successfully, but these errors were encountered: