-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
J244 Static Broken #193
Comments
Can you give me an example of a system that has a J244 static that I can test with? @Skyl3lazer |
https://wiki.eveuniversity.org/List_of_W-space_system has many. Constellation A-C00314: System Static is J244 to Low Sec (10 systems) J125428, J131854, J160534, J144855, J101453, J144913, J144530, J135411, J125713, J105521 Constellation A-C00315: System Static is J244 to Low Sec (9 systems) J224324, J163203, J171818, J145337, J150131, J130842, J145406, J103404, J112124 Constellation A-C00316: System Static is J244 to Low Sec (9 systems) J124926, J232605, J144938, J233828, J130714, J142701, J154226, J125843, J155459 Constellation A-C00317: System Static is J244 to Low Sec (9 systems) J225555, J115549, J140741, J104140, J101757, J100250, J113721, J105039, J233550 Constellation A-C00318: System Static is J244 to Low Sec (12 systems) J114033, J105936, J140121, J154029, J101336, J160039, J161257, J144303, J121131, J113653, J123454, J110750 Constellation A-C00319: System Static is J244 to Low Sec (9 systems) J151106, J100040, J223733, J110431, J134446, J143202, J210436, J133030, J170645 Constellation A-C00320: System Static is J244 to Low Sec (12 systems) J103151, J222206, J130602, J123708, J123831, J164927, J134143, J214534, J135250, J111707, J135245, J101408 Constellation A-C00321: System Static is J244 to Low Sec (12 systems) J215117, J141019, J102206, J125903, J134939, J162641, J152537, J224442, J104138, J121516, J114540, J155013 Constellation A-C00322: System Static is J244 to Low Sec (11 systems) J144450, J141239, J115545, J114905, J120522, J172907, J164550, J141812, J134637, J134132, J125011 Constellation A-C00323: System Static is J244 to Low Sec (12 systems) J105942, J171653, J110213, J115048, J174405, J123111, J123047, J231541, J215900, J110651, J140602, J163804 |
@samoneilll Tagging you for that last comment |
@samoneilll I found the issue. It appears the J244 static appears twice in This can be shown by running the SQL command
Now.. One of these has the proper attributes like target system, max mass, etc. and the other one is an impostor. We can check this by running
As we can see, ID 30667 is the only one with attributes, but testing showed it's being overwritten by ID 73748 during execution of this function: pathfinder/app/Controller/Api/Map.php Line 225 in f37e350
Running I am not sure why or where the error came from, but 30667 as well as 73748 exist in ESI. Running the typeIDs through https://esi.evetech.net/ui/#/Universe/get_universe_types_type_id yields the same, correct, attributes for both typeIDs. My suggested solution would be to become consistent with ESI and add the missing entries for ID 73748 into This command seems to solve this issue: |
@MonoliYoda , thanks for investigating. I'm not quite sure what's happening here. The eve_universe.sql dump we use to populate the static data definitely only has the 30667 entry. I did however notice that the 73748 J244 is in the SDE right next to 73749 J377 which is the turner WH. I wonder if CCP have added a new J244 type specifically for thera, and when you run the setup-page functions to update SDE from ESI you get the new version which over-writes. The only thing I can really think of to solve this is try to edit those functions in setup.php that import data from ESI to add a guard-clause specifically for this one case. |
The J244 static doesn't show with a static icon on wormholes, nor does it have mass/etc information tied to it on mouseover in the statics panel.
I assume there is some sort of DB entry missing to tie it to this information since it looked like there was some there in the flat file, but was unable to find the issue myself to PR.
The text was updated successfully, but these errors were encountered: